Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useIdbKeyval): ability to wait for IDB writes #3338

Conversation

AbdallahAlhaddad
Copy link
Contributor

@AbdallahAlhaddad AbdallahAlhaddad commented Aug 23, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

solves #3336

Additional context


🤖 Generated by Copilot at d1b66db

Add set function to useIDBKeyval hook to support updating the stored value in the IndexedDB. Improve documentation and examples for the hook in index.md.

🤖 Generated by Copilot at d1b66db

  • Add a set function to the useIDBKeyval hook that updates the data ref and the IDB store (link, link)
  • Update the usage examples in index.md to show how to use the set function and how to await the IDB transaction (link, link)
  • Import the watchPausable function from @vueuse/core to create a pausable and resumable watcher for the data ref (link)

@antfu antfu changed the title feat(useIdbKeybal) ability to wait for IDB writes feat(useIdbKeybal): ability to wait for IDB writes Aug 25, 2023
@antfu antfu changed the title feat(useIdbKeybal): ability to wait for IDB writes feat(useIdbKeyval): ability to wait for IDB writes Aug 25, 2023
@antfu antfu enabled auto-merge August 25, 2023 11:29
@antfu antfu added this pull request to the merge queue Aug 25, 2023
Merged via the queue into vueuse:main with commit 77a8627 Aug 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants