Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useSortable): prevent from creating multi instances #3501

Merged
merged 3 commits into from Nov 9, 2023

Conversation

Doctor-wu
Copy link
Member

@Doctor-wu Doctor-wu commented Oct 25, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

fix #3496
prevent start multi instance

Additional context


🤖 Generated by Copilot at 9afb592

This pull request fixes a bug in onClickOutside and improves the performance and reliability of useSortable. It ensures that the onClickOutside function correctly handles null or undefined target elements, and that the useSortable function does not create duplicate Sortable instances.

🤖 Generated by Copilot at 9afb592

  • Fix a bug in onClickOutside that caused incorrect shouldListen value when target element was null or undefined (link)
  • Prevent creating duplicate Sortable instances in useSortable by checking if one already exists for the target element (link)

@Doctor-wu Doctor-wu force-pushed the fix/useSortable_multi_instances branch from 9afb592 to 01fee91 Compare October 25, 2023 03:53
@Doctor-wu Doctor-wu force-pushed the fix/useSortable_multi_instances branch from 01fee91 to 792bd7d Compare October 25, 2023 04:01
@Doctor-wu Doctor-wu changed the title Fix useSortable multi instances fix(useSortable): prevent from creating multi instances Oct 25, 2023
@Alfred-Skyblue
Copy link
Member

We should set sortable to undefined when stopping, and when starting, we should check if sortable exists; if it does, we should not create a new sortable.

@Doctor-wu
Copy link
Member Author

Doctor-wu commented Oct 25, 2023

We should set sortable to undefined when stopping, and when starting, we should check if sortable exists; if it does, we should not create a new sortable.

@Alfred-Skyblue Got you, so I think we need to set the sortable to undefined when the stop function is invoked

@antfu antfu added this pull request to the merge queue Nov 9, 2023
Merged via the queue into vueuse:main with commit d98468d Nov 9, 2023
4 checks passed
@brgkcosic
Copy link

does this inherently then stop from creating recursive groups that can be sorted? I need to implement a functionality that groups items inside, and this group can either render a group item or another group (recursively) - so my logic is to create groups that are sortable and eventual rendering of items when reaching the bottom line.

@Alfred-Skyblue
Copy link
Member

@brgkcosic If you need to perform recursive sorting, you should create a separate sortable instance at each level of recursion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useSortable can start multiple instances of Sortable
4 participants