fix(useScroll): Cannot read properties of null (reading document) #3544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
fixes #3543
Additional context
In the PR #3384, triggered once
setArrivedState
when the component is first mounted.When
element
isnull
,setArrivedState
will still be triggered once.This PR adds a judgment to avoid this problem.
🤖 Generated by Copilot at 45bd3f0
Fix a bug in
useScroll
hook that caused state updates and errors when the element was null or undefined. Add a truthy check fortoValue(element)
before callingsetArrivedState
inpackages/core/useScroll/index.ts
.🤖 Generated by Copilot at 45bd3f0
useScroll
hook that caused unnecessary state updates and potential errors when the element is null or undefined (link)