Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useScroll): Cannot read properties of null (reading document) #3544

Merged
merged 2 commits into from Nov 13, 2023

Conversation

loongzhu
Copy link
Contributor

@loongzhu loongzhu commented Nov 13, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

fixes #3543

Additional context

In the PR #3384, triggered once setArrivedState when the component is first mounted.
When element is null, setArrivedState will still be triggered once.
This PR adds a judgment to avoid this problem.


🤖 Generated by Copilot at 45bd3f0

Fix a bug in useScroll hook that caused state updates and errors when the element was null or undefined. Add a truthy check for toValue(element) before calling setArrivedState in packages/core/useScroll/index.ts.

🤖 Generated by Copilot at 45bd3f0

  • Fix a bug related to the useScroll hook that caused unnecessary state updates and potential errors when the element is null or undefined (link)

Co-authored-by: João Paulo Siqueira Lins <joaopslins@gmail.com>
@antfu antfu merged commit e97427f into vueuse:main Nov 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VueUse 1.6.0 - Cannot read properties of null (reading 'document')
3 participants