Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useMagicKeys: Meta key makes combined key stay active #491

Closed
florivdg opened this issue May 11, 2021 · 2 comments
Closed

useMagicKeys: Meta key makes combined key stay active #491

florivdg opened this issue May 11, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@florivdg
Copy link

There is an issue with useMagicKeys when using the Meta key on a Mac in a combination with other keys that keeps the other pressed key stay active after releasing the keys.

You can actually see this behavior on the useMagicKeys docs itself.
When you open search by pressing MetaLeft + K or MetaRight + K and then let go of the pressed keys you can see the K stay active (see attached GIF).

This is not happening when using a different modifier like Ctrl. Pressing Ctrl + K clears both keys when releasing as it is expected.

meta_key

@wufeng87
Copy link

@florivdg @wheatjs How about to change the behavior to clear all current keys when metaLeft(Right) keyUp on mac? Maybe I could make a pr for that.

@1wkk
Copy link
Contributor

1wkk commented Mar 26, 2022

@wheatjs Maybe it's time to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants