useMediaControls: Overwrites the values set by the attributes

[cawa-93]

vueuse/packages/core/useMediaControls/index.ts

Lines 313 to 320 in ecd6496

	el.loop = unref(options.loop)!
	el.controls = unref(options.controls)!
	el.muted = unref(options.muted)!
	el.preload = unref(options.preload)!
	el.autoplay = unref(options.autoplay)!
	el.volume = unref(volume)!
	;(el as HTMLVideoElement).playsInline = unref(options.playsinline)!
	;(el as HTMLVideoElement).poster = unref(options.poster) || ''

I'm not sure if this was intended, but it overwrites the default (browser) values and those that were set by the attributes.

Example:

<video controls src="">

useMediaControls(video, {})

Expected:

video.controls // true // set by attribute
video.preload // "metadata" // default browser behaviour

Actual:

video.controls // false
video.preload // "auto"

[wheatjs]

Hmm yeah, perhaps whenever the user doesn't specify an option we can default to the attributes. Would you like to make a PR for this? If not I can do it sometime this week

[cawa-93]

Ok. I Create PR tomorrow.

[wheatjs]

Sounds good, thanks 😄