fix(useFetch): parse body even if status is not ok #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fair enough to me. What do you think @wheatjs ? |
|
I think this is good, maybe we can also pass the error to the responseData to the error as well? |
|
Do you mean if (!fetchResponse.ok) {
const error = new Error(fetchResponse.statusText)
error.data = responseData
throw error
}like suggested #526 (comment) |
antfu
approved these changes
Jun 22, 2021
antfu
changed the title
antfu
pushed a commit
to MinatoHikari/vueuse
that referenced
this pull request
Jul 5, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #553fixes #526
While not yet clear what path we should take in order to have access to the response body when the status code is not
okI propose this PR.