fix: useDark demo #604
Merged
fix: useDark demo #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This incorrect usage causes a `MouseEvent` to be passed over to `toggleDark`, which in the current implementation results in never being able to switch back from dark mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 馃摉
This pull request fixes the
useDarkdemo.Background 馃摐
This incorrect usage causes the
MouseEventto be passed over totoggleDark, which in the current implementation results in never being able to switch back from dark mode (when system is not dark).The bug can be replicated in the current VueUse website.
vueuse.mp4
Future Work 馃敭
It might be desirable to log a warning or throw an error if an
Eventis passed to the setter inuseDark, as it's very likely a mistake, and can cause the bug in the video.