Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useAxios): improve type of data #2250

Closed
wants to merge 1 commit into from

Conversation

GODLiangCY
Copy link
Contributor

@GODLiangCY GODLiangCY commented Sep 24, 2022

Description

the type of the returned data should be shallowRef rather than Ref, as it's declared here

closes #2251

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@GODLiangCY
Copy link
Contributor Author

This PR was closed because #2251 gives a better solution

@GODLiangCY GODLiangCY closed this Sep 25, 2022
@GODLiangCY GODLiangCY deleted the feat/useAxios branch September 27, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants