Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(useAnimate): set sync false #3916

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf(useAnimate): set sync false #3916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4f9917
perf(useAnimate): set `sync` false
JianJroh Apr 9, 2024
03d016d
Merge branch 'main' into perf/set-sync-false
antfu May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/core/useAnimate/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { ComputedRef, Ref, ShallowRef, WritableComputedRef } from 'vue-demi'
import { computed, nextTick, shallowReactive, shallowRef, watch } from 'vue-demi'

Check failure on line 2 in packages/core/useAnimate/index.ts

View workflow job for this annotation

GitHub Actions / lint 

'nextTick' is defined but never used

Check failure on line 2 in packages/core/useAnimate/index.ts

View workflow job for this annotation

GitHub Actions / test (18.x) 

'nextTick' is declared but its value is never read.

Check failure on line 2 in packages/core/useAnimate/index.ts

View workflow job for this annotation

GitHub Actions / test (20.x) 

'nextTick' is declared but its value is never read.
import type { MaybeRef, Mutable } from '@vueuse/shared'
import { isObject, objectOmit, toValue, tryOnMounted, tryOnScopeDispose } from '@vueuse/shared'
import type { MaybeComputedElementRef } from '../unrefElement'
Expand Down Expand Up @@ -238,9 +238,7 @@
}
}, { deep: true })

tryOnMounted(() => {
nextTick(() => update(true))
})
tryOnMounted(() => update(true), false)

tryOnScopeDispose(cancel)

Expand Down
Loading