fix(useCssVar): ensure MutationObserver detects CSS variable changes #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rver detects changes - Removed the code responsible for setting the style property within the useCssVar function. - This change was necessary because it caused the MutationObserver not to detect subsequent changes after the style property was initially set. - Now, useCssVar correctly detects changes to the CSS variable using the MutationObserver without interference.
dosubot
bot
added
the
size:XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses an issue with the useCssVar function where the MutationObserver was not detecting changes to CSS variables after the initial style property was set.
Changes:
Removed the code responsible for setting the style property within the useCssVar function.
Ensured that the useCssVar function now correctly detects changes to the CSS variable using the MutationObserver without any interference.
Context:
The original implementation set the style property directly, which prevented the MutationObserver from detecting subsequent changes. By removing this code, the function can now observe changes more reliably, improving its reactivity and functionality.