Improving performance of getting a model/baseModel from entities #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #718 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 1554 1558 +4
Branches 260 262 +2
=========================================
+ Hits 1554 1558 +4
Continue to review full report at Codecov.
|
|
This is awesome. Thank you for taking the time to address this 👍 |
|
@cuebit cheers, happy that I could help 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to decrease the complexity of getting a single model/baseModel from the entities list, as described in the issue #717.
Type of PR:
Breaking changes:
Details
It basically replaces the two reduces found here and here with the javascript find to retrieve a model/baseModel from a list of entities.