Fix favorites multi-select-list storage cleanup after deleting items …

…from lists (#3790)
vufind-org · Jun 14, 2024 · cc1950f · cc1950f
1 parent c0dda59
commit cc1950f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/themes/bootstrap3/js/list_item_selection.js b/themes/bootstrap3/js/list_item_selection.js
@@ -225,7 +225,11 @@ VuFind.register("listItemSelection", function ListItemSelection() {
 
     let nonDefaultIds = _sessionGet(form, 'nonDefaultIds') || [];
     let checkedDefault = _sessionGet(form, 'checkedDefault') || false;
-
+    // Check if the form contains all the ids in the nonDefaultIds
+    const allIds = JSON.parse(form.querySelector('.all-ids-global').value || '[]');
+    if (allIds) {
+      nonDefaultIds = nonDefaultIds.filter(item => allIds.includes(item));
+    }
     form.querySelectorAll('.checkbox-select-item').forEach(itemCheckbox => {
       itemCheckbox.checked = nonDefaultIds.includes(itemCheckbox.value) ? !checkedDefault : checkedDefault;
     });

diff --git a/themes/bootstrap5/js/list_item_selection.js b/themes/bootstrap5/js/list_item_selection.js
@@ -225,7 +225,11 @@ VuFind.register("listItemSelection", function ListItemSelection() {
 
     let nonDefaultIds = _sessionGet(form, 'nonDefaultIds') || [];
     let checkedDefault = _sessionGet(form, 'checkedDefault') || false;
-
+    // Check if the form contains all the ids in the nonDefaultIds
+    const allIds = JSON.parse(form.querySelector('.all-ids-global').value || '[]');
+    if (allIds) {
+      nonDefaultIds = nonDefaultIds.filter(item => allIds.includes(item));
+    }
     form.querySelectorAll('.checkbox-select-item').forEach(itemCheckbox => {
       itemCheckbox.checked = nonDefaultIds.includes(itemCheckbox.value) ? !checkedDefault : checkedDefault;
     });