Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All facets. #10

Closed
wants to merge 1 commit into from
Closed

All facets. #10

wants to merge 1 commit into from

Conversation

demiankatz
Copy link
Member

No description provided.

@demiankatz demiankatz mentioned this pull request Aug 9, 2013
Closed
@demiankatz
Copy link
Member Author

I think this needs some revision -- a few comments:

1.) There's PHP in the check_all_facets.js file; I don't think that's intentional, and it definitely looks like it won't work correctly.
2.) I'm not seeing any code to actually trigger the allFacets() Javascript; is there a file missing from the commit?
3.) The functionality is currently Solr-specific, but it would make sense to extend this so that it is available to all search backends.
4.) I think this should be configurable somehow so that it can be activated on a field-by-field basis (or not at all), since facet fields with huge numbers of values could cause problems otherwise.

@demiankatz
Copy link
Member Author

Superseded by #11.

@demiankatz demiankatz closed this Aug 9, 2013
EreMaijala added a commit to EreMaijala/vufind that referenced this pull request Jun 17, 2015
@EreMaijala
Merge pull request vufind-org#10 from samuli/layout-js
7cbf0a4 
Add module for layout related JavaScript.
crhallberg pushed a commit to crhallberg/vufind that referenced this pull request Jan 21, 2016
@lahmann
Merge pull request vufind-org#10 from crhallberg/introducing_holdings…
d95e0e1 
…_and_item_notes

Switch to Compact List Table
@jochen-lienhard jochen-lienhard mentioned this pull request Feb 17, 2016
Closed
@demiankatz demiankatz deleted the all-facets branch June 4, 2020 18:52
skellamp added a commit to skellamp/vufind that referenced this pull request May 31, 2023
@skellamp
Migrated Ratings Service (vufind-org#10)
32ceb49 
- Includes test suite fixes to make cleanup logic in LiveDatabaseTrait work with Doctrine
@sturkel89 sturkel89 mentioned this pull request Dec 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@demiankatz