Diferent port for database adapter

[horaciod]

need a different port for my database (postgresql listening in port 5434)

TODO:

• Document how to specify the port in config.ini (right now, implemented as part of the database connection string)
• Test with MySQL

[demiankatz]

Thanks for sharing this!

Did you consider specifying the port as part of the connection string? e.g. pgsql://postgres:pass@localhost:5434/databasepostgres? If that doesn't work with the existing code, a bit of extra processing of the $host variable could probably make it work. I don't really object to adding a 'port' setting, but including the port in the connection string might be more consistent with the rest of our approach to database configuration. What do you think?

[horaciod]

Ok, I will work in that approach.

[demiankatz]

Thank you very much! I'm happy to help if you need anything.

[demiankatz]

@horaciod, I had a few moments free, so I pushed up a proposed alternate implementation that makes use of the connection string instead of a separate setting. Do you mind trying this and letting me know if it works for you? It appears upon initial testing that the 'port' setting does not work correctly with the mysqli adapter. Further work may be needed to get this working correctly with all platforms. I am adding a TODO list to the PR comment so we don't forget about this issue (or the need to add documentation in config.ini once we settle on an approach).

[demiankatz]

@horaciod, I was finally able to test this successfully with MySQL; I discovered that if you connect to MySQL on localhost, PHP uses sockets and ignores the port number.... however, by connecting to 127.0.0.1 instead, I was able to confirm that the port setting is being respected.

[demiankatz]

At this point, I'm pretty comfortable that this works -- merging now. Thanks again!