Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voyager: add option to only display time part of due date for short loans. #1047

Merged
merged 4 commits into from Oct 18, 2017

Conversation

EreMaijala
Copy link
Contributor

Motivation: users may get confused thinking that the due time is related to library open hours while that's often not the case.

@demiankatz
Copy link
Member

@EreMaijala, here at Villanova, we have term loans, so the policy matrix interval is 'T' rather than 'D'. That causes this change to fail to behave as expected.

I'm not sure, without doing research, what other values are possible in the matrix. However, I think this feature may need to be made a little more flexible. The question is, do we want to hard-code a more robust solution, or do we want to make the configuration specify which intervals have times displayed?

Any thoughts/preferences?

@EreMaijala
Copy link
Contributor Author

Maybe the right way is to display the time only for 'H'. I'll check what the possible values are and update the code accordingly.

@demiankatz
Copy link
Member

Thanks. That may well be the easiest solution, though checking the possible values first is a good idea. Let me know if I can be of any assistance!

@EreMaijala
Copy link
Contributor Author

Okay, after consulting a Voyager admin I think the best way to do this is to allow to configure the loan interval types for which the time is displayed. The latest commit should achieve this.

@demiankatz demiankatz merged commit 6f02614 into vufind-org:master Oct 18, 2017
@EreMaijala EreMaijala deleted the voyager-duedate branch June 4, 2018 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants