Make Piwik helper more robust. #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EreMaijala shall we discuss the problems of tracking using accordion or tabs in this PR too?
|
|
@jochen-lienhard I don't believe this affects the accordion, so let's keep that separate. |
|
OK, than I wait with a new PR until this is merged. |
|
This looks reasonable to me. I'm merging it now; @jochen-lienhard, please go ahead with your new PR whenever you're ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piwik helper was trying to access the result of ViewModel->getCurrent() without null checking (apart from getCombinedSearchResults, which already did). I encountered this while calling Record helper's renderTemplate() from an AjaxHandler.
Also make the helper try current view for a record driver if there's no current template in the ViewModel.