Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent multiple reply-to addresses in Mailer. #1406

Merged
merged 7 commits into from Aug 23, 2019
Merged

Prevent multiple reply-to addresses in Mailer. #1406

merged 7 commits into from Aug 23, 2019

Conversation

samuli
Copy link
Contributor

@samuli samuli commented Aug 12, 2019

No description provided.

EreMaijala
EreMaijala approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most importantly, this prevents a reply-to address in feedback config from overriding the more important from address override.

@demiankatz
Copy link
Member

@samuli / @EreMaijala, do we need any comments in configuration to explain the order of precedence here? Is there anywhere in the test suite where we can/should cover the scenarios being addressed here?

@samuli
Copy link
Contributor Author

samuli commented Aug 19, 2019

@demiankatz I added some tests and documentation to config.ini.

demiankatz
demiankatz reviewed Aug 22, 2019
View reviewed changes
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be safe to merge now, but before I do, a couple of small items for your consideration... Please let me know what you think!

config/vufind/config.ini Show resolved Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/Mailer/MailerTest.php Show resolved Hide resolved
@demiankatz demiankatz merged commit 2cd1d67 into vufind-org:master Aug 23, 2019
@samuli samuli deleted the mailer-reply-to branch August 23, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demiankatz demiankatz demiankatz left review comments

@EreMaijala EreMaijala EreMaijala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samuli @demiankatz @EreMaijala