Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to League/CommonMark 1.5 #1699

Merged
merged 3 commits into from Sep 8, 2020
Merged

Conversation

demiankatz
Copy link
Member

There is a new minor version of the CommonMark Markdown processor, which includes at least one deprecation affecting VuFind's example configuration. This PR applies the updates and provides a space to review/discuss.

@demiankatz
Copy link
Member Author

@xmorave2, when doing routine dependency updates, I noticed that a new minor version of League/CommonMark was available, but it has some deprecations. I created this PR so you could review the adjustments and let me know if you have any concerns before I merge the updates.

@xmorave2
Copy link
Contributor

xmorave2 commented Sep 7, 2020

@demiankatz Looks good to me. Although there are three new extensions (and they look interesting and useful) we could merge this as is and add reflect new extensions on another PR (I could do it...).

@demiankatz
Copy link
Member Author

Thanks, @xmorave2, I have added a note about the setting deprecation to the changelog; I don't think it's likely that anyone has customized this, so I'm not going to devote the effort to building it into VuFind's auto-upgrader. I can revisit that choice if anyone disagrees.

If you'd like to open a PR with support for the new plug-ins at your convenience, that would be great. Thanks!

@demiankatz demiankatz merged commit a002333 into vufind-org:dev Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants