Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks to Open Library subject recommendation #180

Closed

Conversation

eocarragain
Copy link
Contributor

two minor tweaks to fix issues we encountered:
-- ensure the json response has info on works
-- strip slashes from subject string

@demiankatz
Copy link
Member

I've merged this with a couple of minor tweaks -- an extra isset() check to be sure notices are not triggered, and a simplification of the str_replace code to eliminate a couple of unnecessary lines. Do you mind re-testing against the current master to make sure I didn't break anything?

Thanks for sharing this!

@demiankatz demiankatz closed this Jul 28, 2014
@eocarragain
Copy link
Contributor Author

Thanks. Looks good

oschihin referenced this pull request in swissbib/vufind Aug 14, 2014
oschihin referenced this pull request in swissbib/vufind Aug 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants