Fix problem with i18n of PHTML templates. #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xmorave2, while testing the TemplateBased ContentBlock, I discovered that .phtml templates with language suffixes were not getting loaded as expected. I believe this simple fix (and corresponding unit test) should take care of the problem. Do you mind reviewing and letting me know if I've overlooked anything important? Thanks! |
xmorave2
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
Good catch @demiankatz, this is really bug. Thanks for patching it.
|
Great, thanks for the review, and glad I could help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.