Set of email verification related tweaks #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When email verification is enabled, changing the email address to the currently active address should reset any pending email address verification.
demiankatz
force-pushed
the
dev-email-verify-tweaks
branch
from
7da514d
to
aa3b754
Compare
demiankatz
reviewed
Mar 22, 2021
demiankatz
reviewed
Mar 22, 2021
| { | ||
| if (!empty($user->pending_email)) { | ||
| // Check if the message has already been added | ||
| foreach ($this->flashMessenger()->getInfoMessages() as $message) { |
There was a problem hiding this comment.
Is this necessary? The view helper should already be deduplicating flash messages here. Rather than doing a lot of specific work here, I wonder if we need to fix/improve a pre-existing generic mechanism if things are not working as expected without this.
There was a problem hiding this comment.
Ah, I didn't know about that. Then I believe it's a useless piece of code. I'll remove it.
There was a problem hiding this comment.
@demiankatz Fixed.
EreMaijala
force-pushed
the
dev-email-verify-tweaks
branch
from
aa3b754
to
a4b56ef
Compare
|
Looks good to me. Rebasing now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of individual commits for improving email verification.
First three are fixes to existing functionality, and the last one adds a flash message to the profile page to reming the user about a pending verification.