Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set phpstan memory limit to 2G. #1913

Merged
merged 1 commit into from Apr 9, 2021

Conversation

EreMaijala
Copy link
Contributor

This will avoid running out of memory when PHP's default is too small.

For reference, our branch with our custom module ran out of memory with Travis' 1G limit.

This will avoid running out of memory when PHP's default is too small.
@EreMaijala EreMaijala requested a review from xmorave2 April 9, 2021 08:49
Copy link
Contributor

@xmorave2 xmorave2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree, thanks @EreMaijala

@demiankatz demiankatz merged commit 88f2ffd into vufind-org:dev Apr 9, 2021
@demiankatz
Copy link
Member

Thanks! If we find that this needs to be adjusted again in future, we should consider adding a phpstan_memory_limit property to build.xml with a default value... but for now, the hard-coded is an easy starting point.

@EreMaijala EreMaijala deleted the phpstan-memory-limit branch September 15, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants