Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further improvements to the Alphabrowse controller. #1977

Merged
merged 2 commits into from Jun 3, 2021
Merged

Further improvements to the Alphabrowse controller. #1977

merged 2 commits into from Jun 3, 2021

Conversation

demiankatz
Copy link
Member

  • Consolidate view model initialization
  • Refactor into more support methods for readability
  • Improve validation of config values

@demiankatz
Further improvements to the Alphabrowse controller.
f38a956 
- Consolidate view model initialization
- Refactor into more support methods for readability
- Improve validation of config values
@demiankatz demiankatz mentioned this pull request Jun 3, 2021
Merged
EreMaijala
EreMaijala approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and tested to work properly.

@demiankatz demiankatz merged commit d843245 into vufind-org:dev Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EreMaijala EreMaijala EreMaijala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@demiankatz @EreMaijala