Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user object as usable parameter when building notification emails #2221

Merged
merged 3 commits into from Nov 30, 2021

Conversation

tmikkonen
Copy link
Contributor

When sending due date reminder and scheduled alert emails this addition makes it possible to include the user's first name e.g. in the greeting to present a bit more personal feel to the recipient.

@tmikkonen tmikkonen marked this pull request as draft November 26, 2021 17:56
@demiankatz
Copy link
Member

Thanks, @tmikkonen. I see that this change is causing a test failure; please let me know if you need help figuring that out!

@EreMaijala
Copy link
Contributor

@tmikkonen I think it would make sense to include the whole user object instead of just the firstname. This would allow more flexibility in the template to e.g. do something with the last name if first name is empty.

@demiankatz
Copy link
Member

Thanks, @EreMaijala and @tmikkonen -- this does seem improved... but it seems that tests still need to be adjusted to recognize this change.

@tmikkonen
Copy link
Contributor Author

Seems to have done it.
And I learned something about running tests and only one test locally, so... :)

@tmikkonen tmikkonen marked this pull request as ready for review November 30, 2021 16:51
@demiankatz
Copy link
Member

Looks good! Thanks, @tmikkonen!

@demiankatz demiankatz merged commit 596fc5d into vufind-org:dev Nov 30, 2021
@demiankatz demiankatz changed the title Add firstname as usable parameter when building notification emails Add user object as usable parameter when building notification emails Nov 30, 2021
@tmikkonen tmikkonen deleted the firstname-to-buildemail-params branch November 30, 2021 17:09
EreMaijala pushed a commit to EreMaijala/vufind that referenced this pull request Feb 2, 2022
Fixes a toolbar dropdown focus problem with Safari.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants