Add missing translations for MultiBackend messages. #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @xmorave2 -- just noticed that I broke some tests as well; hopefully I've fixed them now. I'll wait to hear from @EreMaijala before merging this. |
|
@demiankatz Looks good to me! |
EreMaijala
approved these changes
Jan 7, 2022
|
Thanks, @EreMaijala -- merging now! |
EreMaijala
pushed a commit
to EreMaijala/vufind
that referenced
this pull request
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were proposed in discussion on #2196. I'm interested in whether @EreMaijala feels any changes are needed, and also whether @xmorave2 still wishes to move forward with #2196, or if it can/should be closed after this is merged.
Note that no driver-side translation is needed for these messages since translation is handled in the flash message display. (I confirmed that things work as expected).