Include all primary authors in export formats. #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The BibTeX handling was apparently a bit broken for repeated editors as well, should be fixed now. I used the following resources for reference: |
demiankatz
requested changes
Mar 29, 2022
There was a problem hiding this comment.
Thanks, @EreMaijala! A couple of small comments. I also wonder whether it's worth putting in some effort to add tests for these (not necessarily right now, but at some point... this is the kind of code that could benefit from test coverage).
themes/root/templates/RecordDriver/AbstractBase/export-refworks.phtml
Outdated
Show resolved
Hide resolved
themes/root/templates/RecordDriver/AbstractBase/export-bibtex.phtml
Outdated
Show resolved
Hide resolved
demiankatz
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most export formats included all secondary authors but only the first primary author. This adds support for all primary authors and simplifies the code for secondary authors a bit while at it.