Tests For Channel Provider Classes #2644
Conversation
There was a problem hiding this comment.
Thanks for this, @skellamp! I've left a few suggestions on the AlphaBrowseTest -- mostly about clarifying naming/documentation, and also pointing out some PHP language features that might be helpful if you are not already familiar with them (though if you simply prefer not to use them, feel free to ignore those suggestions). I think that some of my feedback probably applies across the other tests as well, so I'm going to let you adjust the first one (and make equivalent changes to the other) before taking the time to do a deep review of everything. Please let me know when you're ready for me to take another look.
module/VuFind/tests/unit-tests/src/VuFindTest/ChannelProvider/AlphaBrowseTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/ChannelProvider/AlphaBrowseTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/ChannelProvider/AlphaBrowseTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/ChannelProvider/AlphaBrowseTest.php
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/ChannelProvider/AlphaBrowseTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/ChannelProvider/AlphaBrowseTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/ChannelProvider/AlphaBrowseTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/ChannelProvider/AlphaBrowseTest.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks, @skellamp -- looking even better; just a few more minor comments.
| public function testGetFromRecord(): void | ||
| { | ||
| $recordDriver = $this->getDriver(['solrField' => 'foo']); | ||
| [$alpha, $expetedResult] = $this->configureTestTargetAndExpectations(); |
There was a problem hiding this comment.
Typo: should be $expectedResult. (Looks like this is copied and pasted in a few places -- hopefully a search-and-replace can easily fix it :-) ).
module/VuFind/tests/unit-tests/src/VuFindTest/ChannelProvider/AlphaBrowseTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/ChannelProvider/RandomTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/ChannelProvider/RandomTest.php
Show resolved
Hide resolved
No description provided.