Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Demo DoiLinker plug-in. #2694

Merged
merged 4 commits into from Feb 3, 2023
Merged

Conversation

demiankatz
Copy link
Member

While testing #2400 I realized there was not an easy way to test DOI linking using the standard test data set, so this PR adds some MARC records with fake DOIs and a Demo DOI linker that generates data for every record with a DOI -- now it's easy to test the UI for DOI links without relying on any external services. In theory, we could also build a Mink test for DOI linking, though I don't think I have time right now.

Copy link
Contributor

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@demiankatz demiankatz merged commit 3fbc699 into vufind-org:dev Feb 3, 2023
@demiankatz demiankatz deleted the doi-demo-driver branch February 3, 2023 12:07
EreMaijala pushed a commit to EreMaijala/vufind that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants