Upgrade to php-cs-fixer 3.14.4, adjust phpcs rules/code to match. #2729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of php-cs-fixer indents case statements according to PSR-12, which differs from the PEAR expectations of PHP_CodeSniffer. Since PSR-12 is a more current standard, it seems sensible to comply with it, so this PR adjust the code according to the new php-cs-fixer behavior and turns off the PHP_CodeSniffer rules that are triggered by the changes. It appears that PHP_CodeSniffer does include PSR-12 support, so a future project to investigate the consequences of changing PHP_CodeSniffer settings more comprehensively might be worthwhile.
Note that beyond the case changes, there are a few other minor adjustments -- php-cs-fixer also now de-indents "implements" in multi-line class declarations and removes more empty lines from functions.