Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to retrieve record links from ILS driver. #2810

Merged
merged 5 commits into from Apr 11, 2023

Conversation

demiankatz
Copy link
Member

@demiankatz demiankatz commented Mar 29, 2023

TODO

  • Test KohaRest driver

@demiankatz
Copy link
Member Author

@EreMaijala, it has been an occasional request to add links directly to the Koha OPAC from VuFind, and this PR is a proof of concept to create a mechanism that allows ILS drivers to provide links to record drivers. I'm interested in your thoughts. In particular:

1.) Can you test the KohaRest changes? I wrote the code but can't easily test it.

2.) Do you think it's sufficient to have a view_in_opac translation string that we can override, or should we make the description configurable via KohaRest.ini?

3.) Any other thoughts on the general architecture here?

Since this adds a new language string, I'm targeting it for the 9.1 release.

@demiankatz demiankatz added this to the 9.1 milestone Mar 29, 2023
@@ -57,6 +57,9 @@ host = "http://koha-server/api"
clientId = ""
; Koha API Client Secret for OAuth2 authentication
clientSecret = ""
; Your Koha OPAC record display URL, if you want to provide direct links to your Koha
; OPAC. Leave this commented out to omit OPAC links.
;opacURL = "http://koha-server/cgi-bin/koha/opac-detail.pl"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works right now, but I'd like the configuration to specify a complete URL with a placeholder for the ID so that the URL can be formulated freely. Something like opacURL = "http://koha-server/cgi-bin/koha/opac-detail.pl?biblionumber=%%id%%" would be great.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've added the suggested flexibility, as well as the beginning of a unit test for the KohaRest driver (currently covering only the newly-added method).

@demiankatz demiankatz merged commit f0687b5 into vufind-org:dev Apr 11, 2023
7 checks passed
@demiankatz demiankatz deleted the opac-links branch April 11, 2023 16:51
demiankatz added a commit that referenced this pull request Apr 17, 2023
(This should be deferred to release 9.1 since it adds a new language string).

This reverts commit f0687b5.
demiankatz added a commit that referenced this pull request Apr 17, 2023
crhallberg pushed a commit to crhallberg/vufind that referenced this pull request Apr 20, 2023
EreMaijala added a commit to EreMaijala/vufind that referenced this pull request Dec 18, 2023
…nd-org#2810)

Also includes a fix for alignment of open/close info and gaps of time intervals in search results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants