Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise version requirement to PHP 8. #2870

Merged
merged 5 commits into from May 11, 2023
Merged

Conversation

demiankatz
Copy link
Member

@demiankatz demiankatz commented May 4, 2023

This PR raises our minimum version requirement to PHP 8, since PHP 7 has reached end of life.

Next steps (to be done in separate PRs):

  • Raise eligible dependency versions (and test)
  • Adjust the PHP version in all file headers (probably best done as a separate PR to reduce confusion)
  • Add PHP 8.2 to the build matrix and to branch protection rules (it doesn't work as of this writing, but updating the dependencies may help).

@demiankatz demiankatz added this to the 9.1 milestone May 4, 2023
@demiankatz
Copy link
Member Author

Note that I've removed the PHP 7.4 build from our branch protection rules, since we won't be able to merge this if a successful 7.4 build is a prerequisite for merges.

@demiankatz demiankatz merged commit e2a5211 into vufind-org:dev May 11, 2023
6 checks passed
@demiankatz demiankatz deleted the php8 branch May 11, 2023 11:18
demiankatz added a commit to demiankatz/vufind that referenced this pull request Jun 13, 2023
EreMaijala pushed a commit to EreMaijala/vufind that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants