Refresh account status when a request is placed. #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensure account status loaded with AJAX is updated. This also fixes an issue where non-lightboxed request redirects to record page with an anchor that prevents any tab from becoming active when initial tab is loaded with AJAX.
|
A note about the implementation: it would be possible to return a refresh response for lightbox that would trigger a reload. That would have the benefit of refreshing the holdings information too, but would change the workflow from the current one, so I opted to do it in a way that doesn't cause visible changes apart from the information getting properly refreshed. |
demiankatz
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Thanks, @EreMaijala! I've added a unit test for the new view helper and my hands-on testing confirms that this fixes the problem with statuses not updating correctly in the drop-down menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures account status loaded with AJAX is updated properly. This also fixes an issue where non-lightboxed request redirects to record page with an anchor that prevents any tab from becoming active when initial tab is loaded with AJAX.
A session helper is used to pass the required flag in session to the refreshed page. Lightbox has been extended to support executing scripts flagged for it.