Exclude FOLIO reserves that have been suppressed from discovery #2935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to exclude course reserves from FOLIO that have instance records marked as suppressed from discovery. We added this to our custom module a while back since it was resulting in a count mis-match (telling the user there were some higher number of course reserves but when they clicked on the reserve result, there were fewer actual reserves because we did not ingest those instance records due to them being suppressed).
The change was added a few years back in the FOLIO API: https://issues.folio.org/browse/MODCR-65 and is documented in their API documentation: https://s3.amazonaws.com/foliodocs/api/mod-courses/r/courses.html#coursereserves_reserves_get.
We thought it would be useful to suggest this change to VuFind, since as a discovery layer, you would expect it to filter suppressed records.