Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude FOLIO reserves that have been suppressed from discovery #2935

Merged

Conversation

meganschanz
Copy link
Contributor

This change is to exclude course reserves from FOLIO that have instance records marked as suppressed from discovery. We added this to our custom module a while back since it was resulting in a count mis-match (telling the user there were some higher number of course reserves but when they clicked on the reserve result, there were fewer actual reserves because we did not ingest those instance records due to them being suppressed).

The change was added a few years back in the FOLIO API: https://issues.folio.org/browse/MODCR-65 and is documented in their API documentation: https://s3.amazonaws.com/foliodocs/api/mod-courses/r/courses.html#coursereserves_reserves_get.

We thought it would be useful to suggest this change to VuFind, since as a discovery layer, you would expect it to filter suppressed records.

Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @meganschanz -- this is a good idea and makes sense to me as a default behavior, but maybe it's worth adding a setting somewhere in Folio.ini to allow suppressed items to be included in case somebody wants to do that for some reason. What do you think?

@demiankatz demiankatz added this to the 9.1 milestone Jun 12, 2023
@meganschanz
Copy link
Contributor Author

Yeah that makes sense, just in case someone wanted those records for some reason.

Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @meganschanz!

@demiankatz demiankatz merged commit 3dc2708 into vufind-org:dev Jun 12, 2023
7 checks passed
@meganschanz meganschanz deleted the exclude-supressed-folio-reserves branch June 12, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants