Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recommendation module for LibGuides Profiles #2977

Merged
merged 30 commits into from
Jul 7, 2023
Merged

Add recommendation module for LibGuides Profiles #2977

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ac48fbf
LibGuides Profile recommendation module
maccabeelevine Jul 3, 2023
413369c
Add email and escape output
maccabeelevine Jul 5, 2023
b39a416
Refactor oauth connection logic
maccabeelevine Jul 5, 2023
9730793
Add documention and clean code
maccabeelevine Jul 5, 2023
8e0af3c
Remove comment
maccabeelevine Jul 5, 2023
ff8e614
Fix log message
maccabeelevine Jul 5, 2023
9e0983f
Document in searches.ini
maccabeelevine Jul 5, 2023
c746cf2
Clarify API documentation link
maccabeelevine Jul 6, 2023
2e9766c
Note CSP requirement
maccabeelevine Jul 6, 2023
2b2baac
Add class property for user agent.
maccabeelevine Jul 6, 2023
6f5d0d6
Simplify if/else condition
maccabeelevine Jul 6, 2023
a9008c5
Document $tokenData class
maccabeelevine Jul 6, 2023
80f1ba3
Fix comments & spacing
maccabeelevine Jul 6, 2023
5b042c6
Remove unused method
maccabeelevine Jul 6, 2023
b865a03
Fix indent
maccabeelevine Jul 6, 2023
b30edc8
Translate heading and fix class names
maccabeelevine Jul 6, 2023
ec97543
Check for empty values
maccabeelevine Jul 6, 2023
8da260b
Handle empty last name.
maccabeelevine Jul 6, 2023
840e62e
Add missing heading
maccabeelevine Jul 6, 2023
7c1ee61
Remove unused $forceNewConnection
maccabeelevine Jul 6, 2023
cc38660
Return null if failure in getAccounts()
maccabeelevine Jul 6, 2023
e80a06e
Create LibGuides connector via factory
maccabeelevine Jul 6, 2023
7f9a5ab
Log only if $this->log exists
maccabeelevine Jul 6, 2023
758e088
Avoid collsions with safe logging
maccabeelevine Jul 6, 2023
71c2ab1
Cache /accounts response
maccabeelevine Jul 6, 2023
31ea155
Fix mention of LoggerAwareInterface
maccabeelevine Jul 6, 2023
78c653f
Remove useless algorithm
maccabeelevine Jul 6, 2023
15ddd33
Fix typo
maccabeelevine Jul 7, 2023
755d8bc
Rename methods for clarity
maccabeelevine Jul 7, 2023
6e261f9
Fix typo
maccabeelevine Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion module/VuFind/src/VuFind/Connection/OauthServiceInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
/**
* Interface for classes using OauthServiceTrait.
*
* Classes which use this trait should also use LoggerAwareTrait.
* Classes which use this trait should also implement LoggerAwareInterface.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"this trait" --> "this interface"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops fixed

*
* @category VuFind
* @package Connection
Expand Down