Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check:scss task and use it in QA to avoid writing out the compile… #3029

Merged
merged 1 commit into from Aug 14, 2023
Merged

Add check:scss task and use it in QA to avoid writing out the compile… #3029

merged 1 commit into from Aug 14, 2023

Conversation

EreMaijala
Copy link
Contributor

…d files.

Also moves the outputStyle setting to the task-specific settings and removes the styleoption that's not used by the node-sass plugin.

demiankatz
demiankatz approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, @EreMaijala.

@demiankatz demiankatz merged commit 09faad7 into vufind-org:dev Aug 14, 2023
7 checks passed
@demiankatz demiankatz deleted the dev-sass-qa branch August 14, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demiankatz demiankatz demiankatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@EreMaijala @demiankatz