New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callnumber improvements #305
Conversation
TODO: introduce 'callnumber-sort' field and investigate the possibility of eliminating the plain 'callnumber' field. |
Okay, I believe this is now complete, but I'll give it a few days for review before merging. |
Generally, I think this looks pretty okay, but will try to test on some local data this week. There are two minor questions in my mind:
|
Thanks, Tod. Regarding the callnumber field type, what would you think of searchable-callnumber, callnumber-search, or some variation like that? I'm happy to change it. Regarding prefixes, I imagine the best approach would depend on the complexity of the prefixing system. It would certainly be possible to add a pattern to strip off prefixes, assuming a simple and easily identifiable scheme. Alternatively, it might also be possible to handle them through munge rules in searchspecs.yaml, if a solution were necessary that didn't involve modifying the Solr schema. I don't think there's any simple way of handling it generically, so some degree of local customization is likely to be necessary no matter what. |
Yes, I think you're on the right track with the name of the field type. Following the camel case convention of the |
Done -- I went with "callnumberSearch" for brevity. Also added a comment on the fieldtype definition for good measure. |
Manually merged. |
Call number handling can be simplified due to improvements in SolrMarc and the AlphaBrowse handler.