Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused imports #3183

Merged
merged 2 commits into from Oct 30, 2023
Merged

Remove unused imports #3183

merged 2 commits into from Oct 30, 2023

Conversation

maccabeelevine
Copy link
Member

Many of these are java.util.Iterator imports that were unused after #2520.

@maccabeelevine
Copy link
Member Author

I tested that it still builds fine and no obvious errors, but didn't do a full indexing exercising everything.

@demiankatz
Copy link
Member

Thanks, @maccabeelevine -- I'm out of office today but will try to give this a closer look next week!

@maccabeelevine maccabeelevine marked this pull request as ready for review October 27, 2023 13:07
@demiankatz demiankatz added this to the 10.0 milestone Oct 30, 2023
demiankatz
demiankatz approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and tests passing.

@demiankatz demiankatz merged commit 68c66e9 into vufind-org:dev Oct 30, 2023
7 checks passed
@maccabeelevine maccabeelevine deleted the java-unused-imports branch October 30, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demiankatz demiankatz demiankatz approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
10.0
2 participants
@maccabeelevine @demiankatz