Trigger errors from AJAX methods in non-production mode. #3267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I intentionally chose to compare with 'production' instead of 'development' so that you can run Mink tests with e.g. 'preproduction' to enable error triggers but keep Whoops disabled. |
|
@demiankatz How about this? Real errors would prevent a response from being generated. Warnings and notices would be logged normally while prevented from being displayed. This would ensure that PHP settings are otherwise in effect just like in all other controllers. |
demiankatz
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Thanks, @EreMaijala, this seems like a reasonable solution to me! I'll make a note about it in the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors in AJAX request could easily go undetected (e.g. #3266) because they were only in the
php_errorselement in AJAX responses. This change makes it so that in non-production mode any errors go through the normal triggers so that they can cause the request to fail and the error to be triggered in debugger.