New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Māori language support. #3317
Conversation
languages/native.ini
Outdated
@@ -22,6 +22,7 @@ Hindi = "हिंदी" | |||
Irish = "Gaeilge" | |||
Italian = "Italiano" | |||
Japanese = "日本語" | |||
Maori = "Māori" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I tried to use "Māori" everywhere instead of "Maori" but the special character caused some problems, so I ended up with "Maori" in config.ini, and this translation to apply the appropriate accent when displaying it in the UI. Not ideal, but I think it should be okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @demiankatz, to be correct we should probably use Maaori if it's impossible to add the special character.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I have adjusted this.
@demiankatz Just wondering about the first term pair in the file I sent you - Abstract = "Whakarāpopotonga". I don't see that in the new mi.ini file. Is this a result of the process you used, a one-off, or should I check thoroughly? |
Good eye, @cmurdoch. I'm not exactly sure how that happened, but I think it's likely to be a one-off. Just for full context, here's what I did: 1.) I deleted the "AUT only" lines from the bottom of the file, since they do not have equivalents in the other languages. ...and that's how we end up where we are now, with a new step 5 of adding back the line I apparently accidentally deleted. :-) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @demiankatz all looks good to me.
This PR incorporates translations provided by @cmurdoch with auto-generated language name translations created using provided tooling. There is still significantly more translation work to do, but this provides a useful starting point.