Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Māori language support. #3317

Merged
merged 7 commits into from Jan 18, 2024
Merged

Add Māori language support. #3317

merged 7 commits into from Jan 18, 2024

Conversation

demiankatz
Copy link
Member

This PR incorporates translations provided by @cmurdoch with auto-generated language name translations created using provided tooling. There is still significantly more translation work to do, but this provides a useful starting point.

@demiankatz demiankatz added this to the 10.0 milestone Jan 17, 2024
@demiankatz demiankatz changed the title Add Maori language support. Add Māori language support. Jan 17, 2024
@@ -22,6 +22,7 @@ Hindi = "हिंदी"
Irish = "Gaeilge"
Italian = "Italiano"
Japanese = "日本語"
Maori = "Māori"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I tried to use "Māori" everywhere instead of "Maori" but the special character caused some problems, so I ended up with "Maori" in config.ini, and this translation to apply the appropriate accent when displaying it in the UI. Not ideal, but I think it should be okay.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @demiankatz, to be correct we should probably use Maaori if it's impossible to add the special character.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I have adjusted this.

@cmurdoch
Copy link

@demiankatz Just wondering about the first term pair in the file I sent you - Abstract = "Whakarāpopotonga". I don't see that in the new mi.ini file. Is this a result of the process you used, a one-off, or should I check thoroughly?

@demiankatz
Copy link
Member Author

Good eye, @cmurdoch. I'm not exactly sure how that happened, but I think it's likely to be a one-off. Just for full context, here's what I did:

1.) I deleted the "AUT only" lines from the bottom of the file, since they do not have equivalents in the other languages.
2.) I ran the language normalization tool to sort the remaining lines into standardized order.
3.) I deleted all of the comments from the top, but added a new one acknowledging you (I suspect at this point, I somehow selected one extra line and accidentally deleted the Abstract translation).
4.) I used the language file comparison tool to identify other unmatched translations in the file -- some of these were due to typos in the keys, others were due to keys becoming obsolete or changing. I fixed, updated or removed all of these as appropriate.

...and that's how we end up where we are now, with a new step 5 of adding back the line I apparently accidentally deleted. :-)

Thanks!

Copy link

@cmurdoch cmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @demiankatz all looks good to me.

@demiankatz demiankatz merged commit 91f4017 into vufind-org:dev Jan 18, 2024
7 checks passed
@demiankatz demiankatz deleted the maori branch January 18, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants