Fix hierarchical facet filters in advanced search. #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And yes, this could use some tests. I'll try to create some when time permits (I have a ticket open locally about it). |
demiankatz
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Thanks, @EreMaijala! As you say, tests will be appreciated when time permits (and should not be too hard to implement since we can just turn on the existing hierarchical_facet_str_mv data for testing purposes), but there's no reason to hold off on merging the fix, so I'll do that now.
EreMaijala
added a commit
to NatLibFi/NDL-VuFind2
that referenced
this pull request
Jan 19, 2024
EreMaijala
added a commit
to NatLibFi/NDL-VuFind2
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had accidentally left some double-processing of hierarchical facets to the advanced search facets handling code, and this resulted in hierarchical facets only displaying the top level in advanced search filters.