Moved conditional rendering for breadcrumbs #3342
Conversation
There was a problem hiding this comment.
Thanks, @FrancescoBrunoDev -- one question/suggestion. I don't have a strong feeling about which approach is better, but I think either way, a minor adjustment is needed.
|
Great! So now it should be correct. I'm just not sure about the indentation because you mentioned it needed to be de-indented by two spaces, but perhaps you meant just one? |
|
Thanks, @FrancescoBrunoDev. The indentation looks good to me. I'll test this as soon as I can and hopefully get it merged in the near future. |
There was a problem hiding this comment.
This looks good to me. I made a small adjustment -- parentheses needed to be added around the showBreadcrumbs check because of the operator precedence of ?? and &&. Eventually it may make sense to eliminate showBreadcrumbs entirely, because as far as I can tell, it is never used... but at least things are generally simplified here!
Thanks again for making this improvement.
Check out #3328 for more information.