Store followup also when logging in with lightbox for SSO. #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the special flag we can ignore it when processing the login but still do a correct redirect with SSO.
demiankatz
requested changes
Jan 29, 2024
There was a problem hiding this comment.
@EreMaijala, maybe I'm misunderstanding something, but I think a little more work may be necessary here.
Also, is there an easy way to capture the behavior change in a Mink test to prevent regressions?
|
@demiankatz Thanks, I've now renamed the flag. I think that a Mink test should be doable, I'll add one. |
demiankatz
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Thanks, @EreMaijala, it's amazing what a little renaming can do. I now understand this a great deal better. I'll just hold off on merging until the test is ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the special flag we can ignore it when processing the login but still do a correct redirect with SSO.
Without the followup there's a discrepancy between library card login and SSO where the former stays on the current page whereas the latter always redirects to MyResearch.