Restrict hostnames for cover proxy. #3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EreMaijala
requested changes
Feb 6, 2024
EreMaijala
reviewed
Feb 6, 2024
EreMaijala
approved these changes
Feb 6, 2024
EreMaijala
pushed a commit
to NatLibFi/NDL-VuFind2
that referenced
this pull request
Feb 6, 2024
EreMaijala
pushed a commit
to NatLibFi/NDL-VuFind2
that referenced
this pull request
Feb 6, 2024
demiankatz
added a commit
that referenced
this pull request
Feb 6, 2024
|
Accidentally merged to dev instead of release-9.1; I manually backported the commit. |
demiankatz
added a commit
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I included assets.thirdiron.com in the example configuration; I'm pretty sure there are no longer any circumstances where we proxy images from this source, but since the cache example still uses it, it seemed more consistent to include it as an example. We can revisit this separately if we want to change all the defaults related to this hostname.