Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use csp()->getNonce() instead of cspNonce() - VUFIND-1510 #3392

Merged
merged 3 commits into from Feb 8, 2024
Merged

Use csp()->getNonce() instead of cspNonce() - VUFIND-1510 #3392

merged 3 commits into from Feb 8, 2024

Conversation

xmorave2
Copy link
Contributor

@xmorave2 xmorave2 commented Feb 7, 2024 •
edited by demiankatz

TODO:

demiankatz
demiankatz requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the lead on this, @xmorave2! Just one small request.

themes/root/theme.config.php Outdated Show resolved Hide resolved
@demiankatz demiankatz removed the request for review from EreMaijala February 8, 2024 12:44
demiankatz
demiankatz approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now; thanks, @xmorave2!

Also nice to see constructor parameter promotion in use -- I didn't realize that was supported already.

@demiankatz demiankatz merged commit dec9cec into vufind-org:dev Feb 8, 2024
7 checks passed
@demiankatz demiankatz deleted the vufind1510 branch February 8, 2024 12:49
@demiankatz demiankatz added this to the 10.0 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demiankatz demiankatz demiankatz approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
10.0
2 participants
@xmorave2 @demiankatz