Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all text to B&W in print view. #3428

Merged
merged 2 commits into from Feb 27, 2024

Conversation

demiankatz
Copy link
Member

This adjusts the print styles to force ALL text to B&W for consistency. This addresses a strange problem identified in #3142.

Before:

image

After:

image

@demiankatz demiankatz added this to the 9.1.2 milestone Feb 16, 2024
@EreMaijala
Copy link
Contributor

@demiankatz What's the role of the added menu-item template here?

@demiankatz
Copy link
Member Author

@EreMaijala, that must have been accidentally committed. It's not related to the change here and has been removed.

@crhallberg
Copy link
Contributor

Do we want to try to minimize this further? I'm not sure we need the link::after clearing any more and we could probably add the hidden-print classes to the action toolbars to remove that specific case at the bottom.

I don't think they're doing any harm, just looking for ways to minimize customization problems.

@demiankatz
Copy link
Member Author

@crhallberg, if you think it's worth investing time in simplifying print.css further, I definitely don't object. But maybe we should approve and merge this first (since this PR is specifically about fixing the text coloration problem) and then follow with a second PR to simplify.

Copy link
Contributor

@xmorave2 xmorave2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is step in the right direction and I agree with @demiankatz that this should be merged as it is, because it is fixing one concrete issue. We could always open another PR for more changes of printing styles.

@demiankatz demiankatz merged commit 003c89d into vufind-org:release-9.1 Feb 27, 2024
7 checks passed
@demiankatz demiankatz deleted the release-9.1-bw-printing branch February 27, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants