Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission plugin improvements #3443

Merged
merged 2 commits into from Feb 23, 2024
Merged

Conversation

aleksip
Copy link
Contributor

@aleksip aleksip commented Feb 23, 2024

This adds context parameter support to the permission controller plugin.

An optional separate commit also adds a getIdentity() method which I have found useful to have here, but am not completely sure if the permission plugin should provide such functionality.

Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aleksip, this makes sense to me.

It may actually be a helpful project to see if there are any places in the code where we can rely on \LmcRbacMvc\Identity\IdentityInterface instead of \VuFind\Db\Row\User. One big remaining piece of the Doctrine migration in #2233 is to refactor the login and identity management code away from Laminas\Db, and if we can reduce the general reliance of the code on the Laminas user row object, that work will likely be simplified. Not sure how likely that is to make a big difference, but it might be worthwhile to investigate at least.

@demiankatz demiankatz merged commit 2d112b2 into vufind-org:dev Feb 23, 2024
7 checks passed
@demiankatz demiankatz deleted the permission-plugin branch February 23, 2024 11:51
@demiankatz demiankatz added this to the 10.0 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants