Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the setting of collectionID #3445

Merged

Conversation

siiriylonen
Copy link
Contributor

No description provided.

@siiriylonen siiriylonen marked this pull request as ready for review February 26, 2024 06:34
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @siiriylonen. I'd be interested to hear a little more about how you plan to use this, just in case there are any further changes needed to fully support your use case. In any case, assuming there is definitely a need for this change, I made a couple of suggestions below that might further improve upon it.

module/VuFind/src/VuFind/RecordDriver/AbstractBase.php Outdated Show resolved Hide resolved
module/VuFind/src/VuFind/Search/SolrCollection/Params.php Outdated Show resolved Hide resolved
@siiriylonen
Copy link
Contributor Author

The intent would be just to make this value easier to customise.
If you mean the further use, it would be then modified to test, if changing the CollectionList tab’s display is something worth doing. (Relating to the closed pr about showing all the items on all archive levels, but at the cost of losing hierarchy structure, so not really a fully functional solution anyway.)

Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @siiriylonen, this looks good to me! I'm just going to wait to merge until I hear if @EreMaijala has any further input to share.

@demiankatz demiankatz merged commit 855429d into vufind-org:dev Feb 29, 2024
7 checks passed
@demiankatz demiankatz added this to the 10.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants