Clarify language and menu interface for saved items.

[demiankatz]

This PR is intended to clarify the labeling of interface elements related to saved items.

It removes three confusing language strings (Favorites, My Favorites, Your Favorites) and replaces them with two more semantically meaningful strings (default_list_title and saved_items).

It also removes the duplicate link to "Saved Items" at the top of the "Your Lists" section of the account menu. This was redundant with the identical link under "Your Account" and was more confusing than helpful.

TODO

• Run full test suite.
• Update changelog when merging (note changed language strings).
• Resolve VUFIND-1592 when merging.

[sturkel89]

The new arrangement in the test branch is cleaner and makes more logical sense to me than what we have on dev. It’s cleaner because of the removal of the redundant Your Favorites in the Your Lists section; in dev, that link gives identical results as Favorites at the top under Your Account.

I like that in test, only ONE item is highlighted at a time – either the Saved Items link at the top of the Your Account section, or a specific list in the Your Lists section.

My only suggestion is that it wouldn’t hurt/might help if there were a circled number next to the superset Saved Items link in the Your Account section giving an overall total number of items saved. That would go above and beyond to differentiate what you get on that list from what’s in an un-renamed Saved Items list under Your Lists, if the user has one generic list and other named lists.

Screenshots from test:

Screenshots from dev:

[demiankatz]

Thanks, @sturkel89. I agree that showing a total of saved items in the menu is a good idea, but it will take a bit of effort to implement. Thus, I'll merge this now for the sake of progress, and will work on that additional improvement as a separate PR when time permits.

[demiankatz]

See VUFIND-1674 for the suggested improvement. I've pinned that ticket to 10.1, since I'm not sure if I'll have time to do it before then. This will ensure it doesn't get forgotten!