Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename UserAccountInterface to UserEntityInterface. #3500

Merged
merged 2 commits into from Mar 12, 2024
Merged

Rename UserAccountInterface to UserEntityInterface. #3500

merged 2 commits into from Mar 12, 2024

Conversation

demiankatz
Copy link
Member

@demiankatz demiankatz commented Mar 12, 2024 •
edited

Following discussion on #3499, this renames the newly-introduced user marker interface to use a better naming convention.

TODO

  • Run full test suite
  • Update changelog when merging (reflect revised interface name)

@demiankatz demiankatz added this to the 10.0 milestone Mar 12, 2024
@demiankatz demiankatz mentioned this pull request Mar 12, 2024
Merged
@demiankatz
Copy link
Member Author

All tests are passing; I think this is probably safe to merge.

@demiankatz demiankatz removed the request for review from aleksip March 12, 2024 15:53
@demiankatz demiankatz merged commit 845e697 into vufind-org:dev Mar 12, 2024
7 checks passed
@demiankatz demiankatz deleted the rename-useraccountinterface branch March 12, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EreMaijala EreMaijala EreMaijala approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
10.0
2 participants
@demiankatz @EreMaijala