Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV importer: Inject dependencies into static callback classes. #3515

Merged
merged 2 commits into from Apr 10, 2024

Conversation

demiankatz
Copy link
Member

Trying to use support methods from the VuFind\XSLT\Import namespace in the CSV importer sometimes failed due to missing dependencies. This PR makes the CSV importer more compatible with the XSLT importer to allow reuse/sharing of helpers.

@demiankatz demiankatz added this to the 9.1.2 milestone Mar 14, 2024
Copy link
Contributor

@xmorave2 xmorave2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@demiankatz
Copy link
Member Author

Thanks, @xmorave2!

@demiankatz demiankatz merged commit 1e0d65c into vufind-org:release-9.1 Apr 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants